Ticket #46 (closed development: fixed)

Opened 4 years ago

Last modified 3 years ago

Increase max TachoLimit in NXC_MotorControl to 999999

Reported by: atorf Owned by: atorf
Priority: low Milestone: v4.04
Component: Toolbox Function Keywords:
Cc:

Description

Currently, NXC_MotorControl checks for a maximum TachoLimit of 99999, but actually the NXC protoco (to MotorControl) uses 6 digits. This would account for 6 digit numbers (if I'm not mistaken), so this max. limit should be increased to 999999?

Having too small limits always pays back in the end some day :-)

But check data-type of all those TachoLimit arguments in NXC before changing this. Was it a real mistake, or by design?

Attachments

Change History

Changed 3 years ago by atorf

  • status changed from new to accepted

Changed 3 years ago by atorf

  • status changed from accepted to closed
  • resolution set to fixed

Fixed with r891. Looks like this was indeed a typo. Crosschecked all data-types in NXC program etc, should all work well…

Changed 3 years ago by behrens

  • milestone set to v4.04

Changed 3 years ago by atorf

For the record: This also had to be fixed inside the NXTMotor class and of course in the documentation. Done with r920.

Add/Change #46 (Increase max TachoLimit in NXC_MotorControl to 999999)

Author



Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.